Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #382 #383

Merged
merged 2 commits into from
Jun 11, 2023
Merged

Fix #382 #383

merged 2 commits into from
Jun 11, 2023

Conversation

mattfbacon
Copy link
Contributor

@mattfbacon mattfbacon commented Jun 6, 2023 •
edited
Loading

A pretty straightforward fix

Fixes #382

@lambda-fairy
Copy link
Owner

lambda-fairy commented Jun 11, 2023 •
edited
Loading

Thanks for the quick fix!

Would you like to add a test for this as well? The example you gave in the bug would be great.

@mattfbacon
Copy link
Contributor Author

Done

lambda-fairy
lambda-fairy approved these changes Jun 11, 2023
View reviewed changes
Copy link
Owner

@lambda-fairy lambda-fairy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lambda-fairy lambda-fairy merged commit 79259ab into lambda-fairy:main Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambda-fairy lambda-fairy lambda-fairy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect expression hygiene results in cryptic errors
2 participants
@mattfbacon @lambda-fairy