Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go.mod for Go modules #1187

Merged
merged 3 commits into from
Sep 4, 2018
Merged

Add go.mod for Go modules #1187

merged 3 commits into from
Sep 4, 2018

Conversation

KimMachineGun
Copy link
Contributor

No description provided.

@KimMachineGun KimMachineGun deleted the add-gomod branch August 29, 2018 04:40
@KimMachineGun KimMachineGun restored the add-gomod branch August 30, 2018 01:33
@KimMachineGun KimMachineGun reopened this Aug 30, 2018
@codecov
Copy link

codecov bot commented Aug 30, 2018 •
edited

Codecov Report

Merging #1187 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1187   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files          25       25           
  Lines        1919     1919           
=======================================
  Hits         1561     1561           
  Misses        250      250           
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9082231...9b4d027. Read the comment docs.

@KimMachineGun
Copy link
Contributor Author

Sync with labstack's master branch.

@vishr
Copy link
Member

vishr commented Aug 30, 2018

@im-kulikov Can you review this?

@im-kulikov
Copy link
Contributor

im-kulikov commented Aug 31, 2018 •
edited

@vishr yep..
github.com/labstack/gommon same issue (#1185)

After version v0.2.1 format was changed...

  • before vX.Y.Z
  • after X.Y.Z

im-kulikov
im-kulikov reviewed Aug 31, 2018
View reviewed changes
echo.go Outdated
@@ -34,7 +34,7 @@ Example:

Learn more at https://echo.labstack.com
*/
package echo
package echo // import "github.com/labstack/echo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not required

im-kulikov
im-kulikov reviewed Aug 31, 2018
View reviewed changes
go.mod Show resolved Hide resolved
im-kulikov
im-kulikov reviewed Aug 31, 2018
View reviewed changes
Copy link
Contributor

@im-kulikov im-kulikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add go.sum

package echo // import "github.com/labstack/echo"

not required

@KimMachineGun
Copy link
Contributor Author

Thank you for reviewing my PR. I will modify that and recommit it ASAP.

@KimMachineGun
Copy link
Contributor Author

I resolved it.

@im-kulikov
Copy link
Contributor

LGTM

@vishr vishr merged commit 54d5613 into labstack:master Sep 4, 2018
@KimMachineGun KimMachineGun deleted the add-gomod branch October 14, 2018 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishr vishr vishr approved these changes

@im-kulikov im-kulikov im-kulikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KimMachineGun @vishr @im-kulikov