added testing for empty Content-Type

labstack · Apr 18, 2023 · 774c166 · 774c166
1 parent bfe99ab
commit 774c166
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/bind_test.go b/bind_test.go
@@ -429,6 +429,10 @@ func TestBindUnsupportedMediaType(t *testing.T) {
  testBindError(t, strings.NewReader(invalidContent), MIMEApplicationJSON, &json.SyntaxError{})
 }
 
+func TestBindErrEmptyContentType(t *testing.T) {
+ testBindError(t, strings.NewReader(invalidContent), "", errors.New("missing content type header"))
+}
+
 func TestBindbindData(t *testing.T) {
  ts := new(bindTestStruct)
  b := new(DefaultBinder)
@@ -674,6 +678,11 @@ func testBindError(t *testing.T, r io.Reader, ctype string, expectedInternal err
  assert.Equal(t, http.StatusBadRequest, err.(*HTTPError).Code)
  assert.IsType(t, expectedInternal, err.(*HTTPError).Internal)
  }
+ case ctype == "": // no content type
+ if assert.IsType(t, new(HTTPError), err) {
+ assert.Equal(t, ErrEmptyContentType, err)
+ assert.IsType(t, expectedInternal, err.(*HTTPError).Internal)
+ }
  default:
  if assert.IsType(t, new(HTTPError), err) {
  assert.Equal(t, ErrUnsupportedMediaType, err)

diff --git a/binder_test.go b/binder_test.go
@@ -4,7 +4,6 @@ import (
  "encoding/json"
  "errors"
  "fmt"
- "github.com/stretchr/testify/assert"
  "io"
  "math/big"
  "net/http"
@@ -13,6 +12,8 @@ import (
  "strings"
  "testing"
  "time"
+
+ "github.com/stretchr/testify/assert"
 )
 
 func createTestContext(URL string, body io.Reader, pathParams map[string]string) Context {