Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix result #4238

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix result #4238

merged 1 commit into from
Nov 3, 2023

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Nov 3, 2023

πŸ€– Generated by Copilot at faaae2e

Summary

πŸ›πŸ› οΈπŸ’°

Fix a bug in GenerateBillingData that caused incorrect cost calculation for applications. Update the unit tests in mongodb_test.go to reflect the correct expected values.

GenerateBillingData
Fixed a bug with division
Costs are accurate

Walkthrough

  • Fix bug in cost calculation by multiplying usage by unit price instead of dividing (link)

@bxy4543 bxy4543 requested a review from lingdie November 3, 2023 03:03
@bxy4543 bxy4543 added this to the v5.0 milestone Nov 3, 2023
@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 970
βœ… Successful 377
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 592
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 3, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@lingdie lingdie merged commit acd4ae3 into labring:main Nov 3, 2023
41 checks passed
@bxy4543 bxy4543 deleted the fix/result branch January 5, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants