Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate keyPair from file #124

Merged
merged 3 commits into from
Apr 2, 2019
Merged

generate keyPair from file #124

merged 3 commits into from
Apr 2, 2019

Conversation

manshuxu
Copy link

@manshuxu manshuxu commented Apr 2, 2019

fix generate keyPair bug

@cuisongliu cuisongliu changed the base branch from master to bugfix April 2, 2019 07:42
@fanux
Copy link
Member

fanux commented Apr 2, 2019

这个可以先merge进来，这样打在镜像里或者使用configmap都能兼容。 如果没有这个文件可以直接使用代码中写死的公钥私钥 @cuisongliu

fanux
fanux reviewed Apr 2, 2019
View reviewed changes
auth/deploy/Dockerfile
@@ -1,4 +1,5 @@
FROM centos:7.6.1810
COPY ./auth/auth .
COPY auth/deploy/start.sh .
ADD /auth/deploy/ssl/ /etc/fist-genKey/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

证书也放 ./auth/auth 目录挺好

@cuisongliu cuisongliu merged commit ef0a533 into labring:bugfix Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanux fanux fanux left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manshuxu @fanux @cuisongliu