Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Administer Winlink password recovery email #445

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Administer Winlink password recovery email #445

merged 4 commits into from
Mar 29, 2024

Conversation

martinhpedersen
Copy link
Member

  • Add CLI command to get/set
  • Print notice if not set

Resolves #442

@martinhpedersen martinhpedersen added this to the v0.16.0 milestone Mar 27, 2024
@martinhpedersen martinhpedersen linked an issue Mar 28, 2024 that may be closed by this pull request
Add Winlink recovery email address to the config file #442
Closed
@martinhpedersen martinhpedersen self-assigned this Mar 28, 2024
xylo04
xylo04 approved these changes Mar 28, 2024
View reviewed changes
internal/cmsapi/password_recovery.go
req := newJSONRequest("GET", PathAccountPasswordRecoveryEmailGet,
url.Values{"callsign": []string{callsign}, "password": []string{password}},
nil).WithContext(ctx)
resp, err := http.DefaultClient.Do(req)
Copy link
Contributor

@xylo04 xylo04 Mar 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth setting a custom User Agent when sending this? buildinfo.UserAgent

@martinhpedersen
Copy link
Member Author

Thanks for the review :) Yes, I think it would be worth setting a custom user agent 😊

@martinhpedersen martinhpedersen merged commit 344f7a7 into develop Mar 29, 2024
4 checks passed
@martinhpedersen martinhpedersen deleted the feature/password-recovery-email branch March 29, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xylo04 xylo04 xylo04 approved these changes

Assignees

@martinhpedersen martinhpedersen

Labels
enhancement
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

Add Winlink recovery email address to the config file
2 participants
@martinhpedersen @xylo04