Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have been working a lot with Omron FINS, initially with Java but am now learning Go. My use is for a commercial product and things seem to be working well.
I don't really know much about Go yet, in terms of conventions or proper program structure, but hopefully what I have done might be of assistance. I have got 99% of the static stuff, like command codes, end codes etc all working. I have also removed a lot of the implementation details from the Frame, Header, Command and Response objects, and moved that into the encode/decode methods. This is a very typical Java way of doing this and may not be appropriate for Go.
Anyway, I hope this is of use and watch out for more commits from me coming.