Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cmake tweaks for Pangolin and Eigen #44

Merged
merged 3 commits into from
Dec 26, 2019

Conversation

rAum
Copy link
Contributor

@rAum rAum commented Dec 20, 2019

There are 2 changes I think should be included:

  1. CMake generates error if Pangolin is not present due to missing ~FindPangolin.cmake file. Pangolin is not a required dependency so find_package should have QUIET.
  2. Improved Eigen thirdparty:
    a) Eigen3 is now a target, not set of variables. This means it's now first-class citizen in terms of cmake dependencies.
    b) this requires to have workaround for some unfortunate mistake on Eigen's part that got deployed on some distributions (Ubuntu for example) - Eigen exported vars but not a library.
    This workaround allows to write code as expected from official Eigen doc: https://eigen.tuxfamily.org/dox-devel/TopicCMakeGuide.html

@kzampog kzampog merged commit 6ca826c into kzampog:master Dec 26, 2019
@kzampog
Copy link
Owner

kzampog commented Dec 26, 2019

Awesome, thanks! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants