Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update panels that used deprecated angular plugins #456

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

tibuntu
Copy link
Contributor

@tibuntu tibuntu commented Jun 21, 2024

Hi there,

Grafana has announced that some plugins that used angular (E.g. graph) are going to be deprecated.
With the new Grafana 11 release, panels using these plugins will not longer work.

See: https://grafana.com/docs/grafana/latest/breaking-changes/breaking-changes-v11-0/#angularjs-support-is-turned-off-by-default

Since we are using Kyverno + Kyverno-Policy-Reporter we would like to update the affected dashboards prior to upgrading Grafana.

I know that it's really hard to properly review the JSON diff. I was able to render all dashboards (ConfigMaps) and was also able to import them into Grafana without any issues.

Let me know if you need more details/infos.

Thanks!

@tibuntu tibuntu force-pushed the replace-angular-grafana-plugins branch from 6875f4b to a3f4e3e Compare June 21, 2024 06:38
@fjogeleit
Copy link
Member

thanks a lot for your support and effort, I will test them locally as well. You can ignore the linting error, I will bump versions when I prepare the release.

@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9609416737

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.663%

Totals Coverage Status
Change from base Build 9544170706: 0.0%
Covered Lines: 5317
Relevant Lines: 5930

💛 - Coveralls

@fjogeleit fjogeleit merged commit 6a1c166 into kyverno:main Jun 24, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants