Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Bucket for S3 targets mendatory and don't show error logs #447

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Make Bucket for S3 targets mendatory and don't show error logs #447

merged 1 commit into from
Jun 8, 2024

Conversation

fjogeleit
Copy link
Member

fix #445

@fjogeleit fjogeleit merged commit 9a90648 into main Jun 8, 2024
3 checks passed
@fjogeleit fjogeleit deleted the fix-s3-configurator branch June 8, 2024 08:50
@coveralls
Copy link

coveralls commented Jun 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9427552724

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 89.609%
Files with Coverage Reduction New Missed Lines %
pkg/helper/gcp.go 3 53.33%
pkg/config/target_factory.go 4 96.71%
Totals Coverage Status
Change from base Build 9276381236: -0.07%
Covered Lines: 5312
Relevant Lines: 5928
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

strange S3 config error when using SecurityHub as target
2 participants
@fjogeleit @coveralls