SecurityHub: fix product name field and allow to set company name #446

balonik · 2024-06-03T13:30:32Z

This PR tries to do 2 things. Both related to better identify Policy Reporter created findings in SecurityHub.

Update productName that it is now populated within ProductName field. Otherwise AWS auto fills Default.
Add option to specify Company name in findings using companyName config option. Otherwise AWS auto fills Personal.

fjogeleit · 2024-06-03T20:50:45Z

Thanks for your contribution.

You can ignore the Helm lint check. I will bump version when I prepare the next release

fjogeleit · 2024-06-07T16:18:03Z

There is one failing test case, could you please check it?

--- FAIL: TestSecurityHub (0.00s)
    --- FAIL: TestSecurityHub/send_result (0.00s)

balonik · 2024-06-08T09:34:50Z

Right, I will get to it on Monday.

balonik · 2024-06-12T07:46:43Z

@fjogeleit sorry for the delay, test should be ok now

…findings Signed-off-by: Peter Jakubis <[email protected]>

balonik force-pushed the target_securityhub branch 4 times, most recently from 230dc4f to 8036727 Compare June 3, 2024 17:21

balonik force-pushed the target_securityhub branch 2 times, most recently from b20289a to 35c1397 Compare June 12, 2024 07:45

balonik force-pushed the target_securityhub branch 3 times, most recently from ecc7d11 to 2c2b1c4 Compare June 12, 2024 14:41

securityhub: fix product name field and allow to set company name in …

4d31cd6

…findings Signed-off-by: Peter Jakubis <[email protected]>

balonik force-pushed the target_securityhub branch from 2c2b1c4 to 4d31cd6 Compare June 12, 2024 15:44

fjogeleit merged commit cc85fee into kyverno:main Jun 12, 2024
2 of 3 checks passed

Provide feedback