URGENT: Feat: Add kind attribute in the Metrics filter #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdul-jabbar01
changed the title
abdul-jabbar01
force-pushed
the
feat/add-kind-attribute-in-metrics-filter
branch
9 times, most recently
from
a0e62c0
to
713fc6b
Compare
Signed-off-by: Abdul Jabbar <[email protected]>
abdul-jabbar01
force-pushed
the
feat/add-kind-attribute-in-metrics-filter
branch
from
713fc6b
to
888566f
Compare
|
I will create a tag for it tomorrow, then you can already using it by using the new tag in your values. |
Thank you very much. Really appreciate your quick response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey. This Pull request adds new attribute
kindin the Metrics filter. Please review and release as soon as possible because we are heavily blocked by this.We have huge metrics and we want to keep the metrics in the backend. But for metrics endpoint, we want to filter based on specific Kind of the resource.
Related MR for docs can be seen here
Thanks in advance :)