Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GoogleCloudCredentials optional to support WorkloadIdentity #433

Merged
merged 1 commit into from
May 8, 2024

Conversation

fjogeleit
Copy link
Member

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9000193029

Details

  • 7 of 10 (70.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 89.748%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/helper/gcp.go 7 10 70.0%
Totals Coverage Status
Change from base Build 8949091467: 0.007%
Covered Lines: 5314
Relevant Lines: 5921

💛 - Coveralls

@fjogeleit fjogeleit merged commit 842e372 into main May 8, 2024
3 checks passed
@fjogeleit fjogeleit deleted the gcs-optional-credentials branch July 28, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants