Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Cleanup Handler to update resolved failures for targets like SecurityHub #426

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Implement Cleanup Handler to update resolved failures for targets like SecurityHub #426

merged 4 commits into from
Apr 23, 2024

Conversation

fjogeleit
Copy link
Member

No description provided.

@fjogeleit fjogeleit linked an issue Apr 20, 2024 that may be closed by this pull request
Add capability for correcting the Kyverno findings in Security Hub automatically #356
Closed
@coveralls
Copy link

coveralls commented Apr 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8800703276

Details

  • 43 of 181 (23.76%) changed or added relevant lines in 20 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 72.817%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/target/discord/discord.go 0 1 0.0%
pkg/target/elasticsearch/elasticsearch.go 0 1 0.0%
pkg/target/gcs/gcs.go 0 1 0.0%
pkg/target/googlechat/googlechat.go 0 1 0.0%
pkg/target/kinesis/kinesis.go 0 1 0.0%
pkg/target/loki/loki.go 0 1 0.0%
pkg/target/s3/s3.go 0 1 0.0%
pkg/target/slack/slack.go 0 1 0.0%
pkg/target/teams/teams.go 0 1 0.0%
pkg/target/telegram/telegram.go 0 1 0.0%
Totals Coverage Status
Change from base Build 8737103310: -1.0%
Covered Lines: 5170
Relevant Lines: 7100
💛 - Coveralls

@fjogeleit
add tests
31972bf 
Signed-off-by: Frank Jogeleit <[email protected]>
@fjogeleit
add delayInSeconds helm value mapping
5a2c9ff 
Signed-off-by: Frank Jogeleit <[email protected]>
@fjogeleit
configure cleanup enabled
3b9e94c 
Signed-off-by: Frank Jogeleit <[email protected]>
@fjogeleit fjogeleit merged commit 5bf9e4b into main Apr 23, 2024
2 of 3 checks passed
@fjogeleit fjogeleit deleted the implement-cleanup-handler branch April 23, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add capability for correcting the Kyverno findings in Security Hub automatically
2 participants
@fjogeleit @coveralls