Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Slack Channel option support #285

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Add Slack Channel option support #285

merged 2 commits into from
Mar 30, 2023

Conversation

fjogeleit
Copy link
Member

No description provided.

@fjogeleit
Add Slack Channel option support
849be0d 
Signed-off-by: Frank Jogeleit <[email protected]>
@fjogeleit fjogeleit linked an issue Mar 30, 2023 that may be closed by this pull request
[core] Slack notification #284
Closed
@coveralls
Copy link

coveralls commented Mar 30, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4565833911

  • 24 of 26 (92.31%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 92.825%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kubernetes/secrets/client.go 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
pkg/config/target_factory.go 2 98.97%
Totals Coverage Status
Change from base Build 4524921611: -0.06%
Covered Lines: 4347
Relevant Lines: 4683
💛 - Coveralls

@fjogeleit
update helm chart
c244608 
Signed-off-by: Frank Jogeleit <[email protected]>
@fjogeleit fjogeleit merged commit 2d85cf9 into main Mar 30, 2023
@fjogeleit fjogeleit deleted the slack-channel-support branch March 30, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core] Slack notification
2 participants
@fjogeleit @coveralls