Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MetadataClient #257

Merged
merged 6 commits into from
Feb 8, 2023
Merged

Implement MetadataClient #257

merged 6 commits into from
Feb 8, 2023

Conversation

fjogeleit
Copy link
Member

Signed-off-by: Frank Jogeleit [email protected]

@fjogeleit fjogeleit force-pushed the meta-informer branch 2 times, most recently from 1eaa2f2 to 3a62f59 Compare February 7, 2023 21:06
@coveralls
Copy link

coveralls commented Feb 7, 2023

Pull Request Test Coverage Report for Build 4125361158

  • 250 of 274 (91.24%) changed or added relevant lines in 17 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 93.551%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/listener/metrics/result_custom.go 16 17 94.12%
pkg/config/resolver.go 29 31 93.55%
pkg/kubernetes/policy_report_client.go 25 27 92.59%
pkg/listener/metrics/cache.go 43 47 91.49%
pkg/kubernetes/queue.go 76 91 83.52%
Files with Coverage Reduction New Missed Lines %
pkg/config/resolver.go 2 98.46%
pkg/sqlite3/store.go 4 86.19%
Totals Coverage Status
Change from base Build 4125322268: -0.09%
Covered Lines: 4004
Relevant Lines: 4280

💛 - Coveralls

pkg/kubernetes/queue.go Outdated Show resolved Hide resolved
@fjogeleit fjogeleit force-pushed the meta-informer branch 2 times, most recently from f2f6a88 to 0ed7da6 Compare February 8, 2023 14:51
Signed-off-by: Frank Jogeleit <[email protected]>
Signed-off-by: Frank Jogeleit <[email protected]>
Signed-off-by: Frank Jogeleit <[email protected]>
Signed-off-by: Frank Jogeleit <[email protected]>
Signed-off-by: Frank Jogeleit <[email protected]>
Signed-off-by: Frank Jogeleit <[email protected]>
@fjogeleit fjogeleit merged commit f3b980b into main Feb 8, 2023
@fjogeleit fjogeleit deleted the meta-informer branch February 8, 2023 14:54
@@ -302,6 +334,16 @@ func (r *Resolver) ReportFilter() *report.Filter {
)
}

func (r *Resolver) InMemoryCache() cache.ItemCache {
if r.cache != nil {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

35% of developers fix this issue

typecheck: invalid operation: cannot compare r.cache != nil (operator != not defined on untyped nil)


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants