Policy Report API #251
Policy Report API #251
Conversation
Signed-off-by: Frank Jogeleit <[email protected]>
Pull Request Test Coverage Report for Build 3967588183
💛 - Coveralls |
Signed-off-by: Frank Jogeleit <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
pkg/api/v1/handler.go
Outdated
| func PolicyReportListHandler(finder PolicyReportFinder) http.HandlerFunc { | ||
| return func(w http.ResponseWriter, req *http.Request) { | ||
| filter := buildFilter(req) | ||
| count, err := finder.CountPolicyReports(filter) |
There was a problem hiding this comment.
SA4006: this value of err is never used
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
pkg/api/v1/handler.go
Outdated
| func ClusterPolicyReportListHandler(finder PolicyReportFinder) http.HandlerFunc { | ||
| return func(w http.ResponseWriter, req *http.Request) { | ||
| filter := buildFilter(req) | ||
| count, err := finder.CountClusterPolicyReports(filter) |
There was a problem hiding this comment.
SA4006: this value of err is never used
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
pkg/api/v1/handler.go
Outdated
| func PolicyReportListHandler(finder PolicyReportFinder) http.HandlerFunc { | ||
| return func(w http.ResponseWriter, req *http.Request) { | ||
| filter := buildFilter(req) | ||
| count, err := finder.CountPolicyReports(filter) |
There was a problem hiding this comment.
ineffassign: ineffectual assignment to err
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
pkg/api/v1/handler.go
Outdated
| func ClusterPolicyReportListHandler(finder PolicyReportFinder) http.HandlerFunc { | ||
| return func(w http.ResponseWriter, req *http.Request) { | ||
| filter := buildFilter(req) | ||
| count, err := finder.CountClusterPolicyReports(filter) |
There was a problem hiding this comment.
ineffassign: ineffectual assignment to err
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Signed-off-by: Frank Jogeleit <[email protected]>
No description provided.