Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add support for signmessagewithname and verifymessagewithname #365

Merged
merged 2 commits into from
Jun 13, 2021
Merged

feature: add support for signmessagewithname and verifymessagewithname #365

merged 2 commits into from
Jun 13, 2021

Conversation

chikeichan
Copy link
Contributor

signverify

RobertLowe
RobertLowe approved these changes Jun 13, 2021
View reviewed changes
Copy link

@RobertLowe RobertLowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat.

Heads up for reviewers, npm install hsd is updated. To verify you need the signature AND message.

👍

@Falci
Copy link
Contributor

Falci commented Jun 13, 2021

There are some layout issues.
image

@chikeichan chikeichan changed the title feature: add support for signmessagewithname and verifymessagewithname feature: add support for signmessagewithprivkey and verifymessagewithprivkey Jun 13, 2021
@chikeichan chikeichan changed the title feature: add support for signmessagewithprivkey and verifymessagewithprivkey feature: add support for signmessagewithname and verifymessagewithname Jun 13, 2021
@rithvikvibhu rithvikvibhu linked an issue Jun 13, 2021 that may be closed by this pull request
[Feature] Sign & verify signed messages #159
Closed
@chikeichan chikeichan merged commit 55f9985 into master Jun 13, 2021
@chikeichan chikeichan deleted the sv branch June 20, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertLowe RobertLowe RobertLowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Sign & verify signed messages
3 participants
@chikeichan @Falci @RobertLowe