suggest saving to normal dependencies #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This library will most likely be built into production, so it makes sense to install it as a normal dependency.
Closed
kyleshevlin
requested changes
Jan 23, 2018
README.md
Outdated
| @@ -13,13 +13,13 @@ ShevyJS takes the concepts of the original [Shevy](https://github.com/kyleshevli | |||
| Shevy is available as a module from npm: | |||
|
|
|||
| ``` | |||
| npm install shevyjs --save-dev | |||
| npm install shevyjs --save | |||
There was a problem hiding this comment.
Think we can even drop --save since it defaults to a dependency.
There was a problem hiding this comment.
Ahh yes, in the olden days of npm it didn't
|
Closes #5 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library will most likely be built into production, so it makes sense to install it as a normal dependency.