Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update [email protected] (docker.socket) #436

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

benoitv-code
Copy link
Contributor

Since version 1.12, Docker removed docker.socket https://docs.docker.com/release-notes/docker-engine/

The problem was already present on RPM systems (e.g. RHEL, Fedora, CentOS), and now also seems to affect Debian 9 (Stretch).

This change replaces docker.socket by docker.service.

It solves this problem:

> systemctl start [email protected]
Failed to start [email protected]: Unit docker.socket not found.

Related issues:

@benoitv-code benoitv-code changed the title Update [email protected] (docket.socket) Update [email protected] (docker.socket) Nov 8, 2018
Since version 1.12, Docker removed `docker.socket` <https://docs.docker.com/release-notes/docker-engine/>

The problem was already present on RPM systems (e.g. RHEL, Fedora, CentOS), and now also seems to affect Debian 9 (Stretch).

This change replaces `docker.socket` by `docker.service`.

It solves this problem:

```
> systemctl start [email protected]
Failed to start [email protected]: Unit docker.socket not found.
```

Related issues:

 - <kylemanna#280>
 - <kylemanna#286>
@marios88
Copy link

This fixed it for me on Debian 9

@enricoba
Copy link

This fixed it for me on CentOS7.

@dominiklessel
Copy link

Any chance to get this merged? Tried it on Ubuntu 18.04.1 LTS and it works fine!

@kylemanna
Copy link
Owner

I guess I have mixed feelings about this. I wish other distros would use socket activation so the docker daemon is started-up as needed as opposed to starting it up when the whole system comes thundering to life. But, I suppose anyone running a container would be starting it up at boot time anyways.

@kylemanna
Copy link
Owner

Actually, I supposed docker.socket starts docker.service when activated. Perhaps this is more flexible.

@kylemanna kylemanna merged commit 04df478 into kylemanna:master Jan 23, 2019
@benoitv-code benoitv-code deleted the patch-1 branch January 23, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants