Only include client-to-client directive if exact 1 #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be more consistent with the rest of the config behavior i propose this config value to be only applied if it's value is exactly 1. Otherwise it is opaque whether the config is applied or not. Providing a value of 0 to turn the config of results in turning it on.
kylemanna
force-pushed
the
dev
branch
2 times, most recently
from
34fc5a3
to
192ce97
Compare
BirdDev
added a commit
to BirdDev/docker-openvpn
that referenced
this pull request
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be more consistent with the rest of the config behavior i propose this config value to be only applied if it's value is exactly 1. Otherwise it is opaque whether the config is applied or not. Providing a value of 0 to turn the config of results in turning it on.