Advanced client management #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypid
force-pushed
the
getclient
branch
2 times, most recently
from
bc266bd
to
e6e2221
Compare
| @@ -37,7 +37,7 @@ Upstream links: | |||
|
|
|||
| * Retrieve the client configuration with embedded certificates | |||
|
|
|||
| docker run --volumes-from $OVPN_DATA --rm kylemanna/openvpn ovpn_getclient CLIENTNAME > CLIENTNAME.ovpn | |||
| docker run --volumes-from $OVPN_DATA --rm kylemanna/openvpn ovpn_getclient CLIENTNAME combined > CLIENTNAME.ovpn | |||
There was a problem hiding this comment.
Can you make the default combined and not specify it? There are existing tutorials that will break (https://www.digitalocean.com/community/tutorials/how-to-run-openvpn-in-a-docker-container-on-ubuntu-14-04) instantly with this change.
Advanced users will easily find the usage / docs for these features. It's distracting to first timer and less advanced users.
There was a problem hiding this comment.
I started with combined being the default, but then I thought, that the other feature might not be visible to the user this way. So I made it explicate. But ok, I will change it back.
|
Number of comments, once they are cleaned-up it should be good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/ypid/docker-openvpn/blob/getclient/docs/clients.md