Enhance the openvpn.conf #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leibaogit
commented
Jan 13, 2017
- Add -U option for the duplication option;
- Update the push route can only use the net mask. Changed to IP/prefix as the -r option
2: Update the push route can only use the net mask. Changed to IP/prefix as the -r option
Enhance the openvpn confige generater
pieterlange
reviewed
Jan 13, 2017
| @@ -118,7 +119,7 @@ process_push_config() { | |||
| local ovpn_push_config='' | |||
| ovpn_push_config="$1" | |||
| echo "Processing PUSH Config: '${ovpn_push_config}'" | |||
| [[ -n "$ovpn_push_config" ]] && echo "push $ovpn_push_config" >> "$TMP_PUSH_CONFIGFILE" | |||
| [[ -n "$ovpn_push_config" ]] && echo "push $(getroute $ovpn_push_config)" >> "$TMP_PUSH_CONFIGFILE" | |||
There was a problem hiding this comment.
I get what you're trying to do here... but this section of for arbitrary push options, not only route pushes.
* Implicit creation seems to have issues. * Resolves issue kylemanna#175
…fore the fix, the openvpn.conf set "push 192.168.10.0 255.255.255.0" format in the push configuration, but this is not correct. It should be "push "route 192.168.10.0 255.255.255.0"".
|
Few trivial issues with this PR:
But more importantly, the The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.