Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using easyrsa release tarballs #18

Closed
wants to merge 1 commit into from

Conversation

cardoe
Copy link

@cardoe cardoe commented Dec 5, 2014

Instead of using easyrsa directly from git, use a release tarball. Even though its just a release candidate for now.

Instead of using easyrsa directly from git, use a release tarball.
@kylemanna
Copy link
Owner

Hi,

Thanks for the pull request. What's the motivation for this?

I see the tarballs as likely smaller due to missing history, but that
could be accomplished with git clone --depth 1 and using an
appropriate tag, now that they exist.

The git approach allows bug fixes to be added easier should they be
necessary or enable new features like EC certs.

On Fri, Dec 05, 2014 at 01:26:35PM -0800, Doug Goldstein wrote:

Instead of using easyrsa directly from git, use a release tarball. Even though
its just a release candidate for now.

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

You can merge this Pull Request by running

git pull https://github.com/cardoe/docker-openvpn easyrsa-release

Or view, comment on, or merge it at:

#18

Commit Summary

• Switch to using easyrsa release tarballs

File Changes

• M Dockerfile (13)

Patch Links:

https://github.com/kylemanna/docker-openvpn/pull/18.patch
https://github.com/kylemanna/docker-openvpn/pull/18.diff


Reply to this email directly or view it on GitHub.*

@cardoe
Copy link
Author

cardoe commented Dec 6, 2014

The idea was to use specific releases. Checking out a specific tag is no different than installing a specific tarball. You can get bug fixes and new features by switching to a new tarball. If you prefer the git method feel free to close this.

@cardoe
Copy link
Author

cardoe commented Dec 6, 2014

Looks like that's your preference and you also incorporated one of the other patches from my repo.

@cardoe cardoe closed this Dec 6, 2014
@kylemanna
Copy link
Owner

The problem is that when I originally created the Dockerfile the releases weren't tagged. That changed some time back. Using git is nicer because at some point I could use git tag --verify among other things for security sensitive software.

As for the other commit, which commit are you referring to? I didn't see any other pull requests?

@cardoe cardoe deleted the easyrsa-release branch December 8, 2014 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants