New: closeExisting property (aka "multiple instances", fix #101) #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, really nice work. If possible, can you add a demo to You could also run the min/changelog gulp tasks to prepare for a patch release, or I can do that after merging.
It's probably fine as is — we can add/change events later depending on user feedback. thanks again! |
|
Done. Happy merging ^^ |
kylefox
added a commit
that referenced
this pull request
Mar 17, 2016
New: closeExisting property (aka "multiple instances", fix #101)
|
Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #127. It has been merged against the latest version of the plugin.
In particular, due to the changes introduced in #110, I had to create a blocker for each modal. But that's fine since it fixes the issue described here.
Demo here.
I haven't included any new event, as I'm not sure how you see it. I understand that we should notify the user when we enter and exit the modal state, but maybe you'd like to separate each event in two (before/after), in the same way as you've defined "before_block" and "block".