Usability Issue: Allow scrolling

[aleemb]

This is one that a lot of modals get wrong (but if you look at any major site, they get it right).

If the content of the modal is too large to fit on screen, users should be able to scroll the modal content (especially images). I settled on this plugin but this usability issue is a show-stopper.

You can test this by making the browser really small on the demo page and loading a modal which doesn't fit. Then try scrolling.

[kylefox]

I believe the issue you're describing is being addressed in #67.

[aleemb]

I think that issue limits the modal height, instead of solving the scrolling issue. The Bootstrap modal demo explains this better:

http:https://getbootstrap.com/javascript/#modals (click "launch demo modal" button)

Previously bootstrap got it wrong. This is the older, less user-friendly behavior:

http:https://getbootstrap.com/2.3.2/javascript.html#modals

[aleemb]

Related: https://github.com/aroc/Bootstrap-Scroll-Modal

[kylefox]

Ok, I see what you mean — rather than give the modal window a fixed height and have the inner content scroll, the modal is full height (even if clipped) and the entire page scrolls.

I like this behaviour better than the fixed height in #67. However it's unlikely I'll have a chance to implement it any time soon.

If you created a pull request I'd love to merge this functionality!

[aleemb]

I capitulated to https://github.com/samdark/the-modal for now

[lukaseder]

I came across this as well, and I fixed it by patching the plugin to use absolute positioning rather than fixed positioning, and by recalculating the marginLeft property every time the window is resized. Not sure if this would be useful to others, too