Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$.modal.close() return element #39

Closed
zjr opened this issue Apr 6, 2013 · 2 comments
Closed

$.modal.close() return element #39

zjr opened this issue Apr 6, 2013 · 2 comments

Comments

@zjr
Copy link
Contributor

zjr commented Apr 6, 2013

In Readme:

TODO: this should be changed so that when called on a specific element, the element is returned (normal jQuery fashion).

Why not return the element whenever $.modal.close() is called?
zjr added a commit to zjr/jquery-modal that referenced this issue Apr 6, 2013
@zjr
Would close kylefox#39 if necessary
d9fd7f1
@kylefox
Copy link
Owner

kylefox commented Apr 6, 2013

Yeah I think that could work! Could you update the README and submit as a pull request?

@zjr
Copy link
Contributor Author

zjr commented Apr 6, 2013

Absolutely 😄

@kylefox kylefox closed this as completed in 04e8fad Apr 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kylefox @zjr