Moved static methods from $.fn.modal to $.modal #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new object $.modal which does most of the things and added static properties to it. We now have: * $.modal.defaults * $.modal.close * $.modal.resize * $.modal.BEFORE_CLOSE (and other constants)
kylefox
added a commit
that referenced
this pull request
Feb 18, 2012
kylefox
added a commit
that referenced
this pull request
Feb 18, 2012
Moved static methods from $.fn.modal to $.modal
|
Awesome, thanks! No idea why this didn't merge cleanly, but all your changes are now in master. |
|
Who knows...maybe it was because of the minor bug fixing done before... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new object $.modal which does most of the things and added static properties to it.
We now have: