Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close/resize functions should not be prototype methods #4

Closed
kylefox opened this issue Apr 27, 2011 · 1 comment
Closed

close/resize functions should not be prototype methods #4

kylefox opened this issue Apr 27, 2011 · 1 comment

Comments

@kylefox
Copy link
Owner

kylefox commented Apr 27, 2011

Calling $.fn.modal.close(); and $.fn.modal.resize() is a bit gross. These methods behave as functions because they close the current modal, regardless of which object they were invoked upon.

A more correct solution would be $.modal.close() and $.modal.resize()

  • This would be a backwards-incompatible change and thus the version number should be bumped accordingly.
  • Don't forget to update README.
@adiospace
Copy link
Contributor

Hi Kyle,

I had some spare time today, so I did this too. Take a look at #10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants