Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable twofish as an optional dependency #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blim747
Copy link

@blim747 blim747 commented Mar 15, 2021

Problem:

As of now pyjks requires the install of twofish, even though according to the README twofish is only required to read UBER keystores. twofish is a package that has no commits since 2013 and is not compatible with Python 3.3+. Installing twofish should be optional.

Solution:

Enable twofish to be installed as an extras_require.

Testing:

I was able to build with Python 2 and Python 3 without issues, with and without twofish. tox tests pass for all Python versions there are tests for.

Notes:

  • See Move off requirements.txt and enable twofish as an optional install #68 for the previous draft version of this PR with a polluted commit history. The previous change included various changes to setup.cfg and requirements.txt that are not required to enable twofish to be installed optionally.
  • Question: Can we increment the version number as part of this change?

@Warkdev
Copy link

Warkdev commented Jan 25, 2024

Any chance to see this merged and released ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants