Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: typo of file and func name #639

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Conversation

Flying-Tom
Copy link
Contributor

@Flying-Tom Flying-Tom commented Jun 1, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Some typo found:

  • pkg/plugin/prometheus/pulgin.go
  • Render method name of some plugins of fleet-manager

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@kurator-bot
Copy link
Collaborator

Welcome @Flying-Tom! It looks like this is your first PR to kurator-dev/kurator 🎉

Copy link

netlify bot commented Jun 1, 2024

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit f6f7b56
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/665d28b449db43000890ec50

Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Flying-Tom Flying-Tom changed the title Fix: typo of plugin filename Fix: typo of file and func name Jun 2, 2024
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@hzxuzhonghu
Copy link
Member

Please fix DCO,
In your local branch, run: git rebase HEAD~2 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin typo-fix

@zirain
Copy link
Contributor

zirain commented Jun 29, 2024

/approve

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, zirain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zirain
Copy link
Contributor

zirain commented Jun 29, 2024

/lgtm

@kurator-bot kurator-bot merged commit 69888be into kurator-dev:main Jun 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants