bin() now understands booleans

kunparekh18 · May 24, 2017 · ed0059a · ed0059a
1 parent fc57aa6
commit ed0059a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/batavia/builtins/bin.js b/batavia/builtins/bin.js
@@ -15,11 +15,16 @@ function bin(args, kwargs) {
 
  var obj = args[0]
 
- if (!types.isinstance(obj, types.Int)) {
+ if (!types.isinstance(obj, types.Int) &&
+ !types.isinstance(obj, types.Bool)) {
  throw new exceptions.TypeError.$pyclass(
  "'" + type_name(obj) + "' object cannot be interpreted as an integer")
  }
 
+ if (types.isinstance(obj, types.Bool)) {
+ return new types.Str('0b' + obj.__int__().toString(2))
+ }
+
  return new types.Str('0b' + obj.toString(2))
 }
 bin.__doc__ = 'bin(number) -> string\n\nReturn the binary representation of an integer.\n\n '

diff --git a/tests/builtins/test_bin.py b/tests/builtins/test_bin.py
@@ -19,6 +19,5 @@ class BuiltinBinFunctionTests(BuiltinFunctionTestCase, TranspileTestCase):
  functions = ["bin"]
 
  not_implemented = [
- 'test_bool',
  'test_int',
  ]