docs: unify package name styling #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulshekhar
requested changes
Aug 30, 2017
README.md
Outdated
| @@ -71,25 +71,25 @@ This setup should allow you to write Jest tests in Typescript and be able to loc | |||
| From version `"jest": "17.0.0"` we are using same MAJOR.MINOR as [`Jest`](https://github.com/facebook/jest). | |||
| For `"jest": "< 17.0.0"` use `"ts-jest": "0.1.13"`. Docs for it see [here](https://github.com/kulshekhar/ts-jest/blob/e1f95e524ed62091736f70abf63530f1f107ec03/README.md). | |||
|
|
|||
| You can try using `ts-jest` with `jest@test`; use at your own risk! (And file an issue if you find problems.) | |||
| You can try using ts-jest with *jest@test*; use at your own risk! (And file an issue if you find problems.) | |||
There was a problem hiding this comment.
I think backticks provide better readability for package@versions
There was a problem hiding this comment.
Yeah, I've had doubt about that.
|
I don't think there's any harm in removing the "VS Code limitations" section from the readme as part of this PR (as discussed in #212). Thoughts? |
|
OK, wait a moment |
|
@kulshekhar I ran Isn't that a problem to you? |
|
I'm not sure yet but I don't see a problem. Push the changes in. I'll take a look. |
kulshekhar
approved these changes
Aug 30, 2017
|
Yeah I think I forgot to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #273
Feel free to add any comment.