Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): make sure LanguageService updated with test file information before getting diagnostics for test file #1507

Merged
merged 3 commits into from
Apr 7, 2020
Merged

fix(compiler): make sure LanguageService updated with test file information before getting diagnostics for test file #1507

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64e724a
fix(compiler): read test file content before doing type check
ahnpnl Apr 6, 2020
3f95153
fix(compiler): update language service before doing type check
ahnpnl Apr 6, 2020
2ff362d
Merge branch 'master' into fix-compiler
ahnpnl Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(compiler): read test file content before doing type check
  • Loading branch information
@ahnpnl
ahnpnl committed Apr 6, 2020
commit 64e724a9a2163260f68dbb4e6d6fa256ba75a157
10 changes: 3 additions & 7 deletions e2e/__cases__/diagnostics/main.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
import { Thing } from "./main";
import { foo, Thing } from './main';

export const thing: Thing = { a: 1 };

function doTheThing() {
return 1 + 2;
}

it("should do the thing", () => {
expect(doTheThing()).toEqual(3);
test('foo is 42', () => {
expect(foo).toBe(42);
});
1 change: 1 addition & 0 deletions e2e/__cases__/diagnostics/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export const foo = 42
export type Thing = { a: number, b: number }
Loading