Memo individual novels #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges. Slanker defaultkonfigurationen.
- Argumentet BUILD_MODE styrer nu hvilken konfiguration af Korp der bygges. - Tilføjer en masse forskellige versioner af “app/“. - Slanker defaultkonfigurationen. - Fjerner korpus-vrt-filer fra git -- undtagen det lille testkorpus. - Nye encodingscripts samt lanchart_mode til LANCHART-dataene …
simongray
approved these changes
Nov 2, 2020
|
... men lad være med at merge før du har squashed! Lav evt. et midlertidigt separat branch du kan øve det på, så du ikke ved et uheld kommer til at miste kode. |
|
Du mergede uden at squashe... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards Docker/Korp setup according to CLI argument/envvar.
We're working towards supporting different custom setups of Korp.
These changes make it possible to build one of several custom setups according to a single CLI argument.
Each custom setup has its own custom version of the frontend/app/ directory.
Each of these folders is partly redundant, leading to a lot of added code.
However, they are the correct unit for a single self-contained frontend config of Korp:
Each represents a separate setup of Korp where changes must be made simultaneously to several files,
some of which would break the other setups.
Another partly redundant addition comes from the CWB encoding scripts in backend/corpora/encodingscripts/.
Some of these are autogenerated.
They could be refactored to a single shell script.
For now, they are not because in each case, a long list of arguments would be required,
which would probably have to be stored in a file anyway.
The script encode.sh is where the corpora to be encoded are selected.
Based on the single CLI argument to docker-compose.
The script create_MEMOconfigs.py is run from the MEMO encoding scripts.
This saves the manual work of creating Korp configs for the MEMO corpora.
There are changes to both backend and frontend Dockerfiles and start scripts, and to the docker-compose file.
The changes support the CLI argument functionality.
An important change consists of setting the CWB registry to a folder on the image rather than the host.
Obsolete files removed: