Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add ical file support for daily planner #104

Closed
wants to merge 7 commits into from
Closed

Feat: add ical file support for daily planner #104

wants to merge 7 commits into from

Conversation

ipapast
Copy link

@ipapast ipapast commented Jan 3, 2024

This PR adds a basic event display on the daily planner. It renders like this:

image

What it acutally does:

  • adds a flag ICAL where a user can point to an .ical file location.
  • loads the ical file, parses it, and displays them in the daily planner template.
  • adds a test for the calendar parser

The daily planner Notes are shrunk a bit so that we can get a few events in the same space.
I have chosen to only include events that have a UTC timestamp (with 'Z') as handling all cases manually and getting timezones in regard is hard. Maybe that can be an additional feature.

How to run:

PLANNER_YEAR=2024 \
PASSES=1 \
CFG="cfg/base.yaml,cfg/template_breadcrumb.yaml,cfg/sn_a5x.breadcrumb.default.yaml" \
NAME="sn_a5x.breadcrumb.default" \
ICSFILE="app/components/icsparser/example_calendar.ics" \ 
./single.

Any comments on making it better/easier are welcome

@ipapast ipapast changed the title Feat/add ical file support for daily planner Feat: add ical file support for daily planner Jan 3, 2024
@kudrykv
Copy link
Owner

kudrykv commented Jan 13, 2024

Hi @ipapast!
Can you please check out rubify branch?
Ultimately, I want to upgrade the repository to that version.
Could you please estimate how hard would it be to implement ical there?

@ipapast
Copy link
Author

ipapast commented Jan 15, 2024

Hi @ipapast! Can you please check out rubify branch? Ultimately, I want to upgrade the repository to that version. Could you please estimate how hard would it be to implement ical there?

Hey, I'll have a look today and let you know :)

@ipapast
Copy link
Author

ipapast commented Jan 18, 2024

Hi @ipapast! Can you please check out rubify branch? Ultimately, I want to upgrade the repository to that version. Could you please estimate how hard would it be to implement ical there?

Alright, I need to re-work this PR because I have forked main only. I will fork the entire repo again, so possibly this PR will be closed. I will open a new one after, if that happens.

@philipsd6
Copy link

Personally, I'd rather have the ical data put right in the schedule, and leave the notes section for notes! But I obviously understand that's a more significant challenge...

@ipapast ipapast closed this by deleting the head repository Jan 21, 2024
@ipapast
Copy link
Author

ipapast commented Jan 22, 2024

Personally, I'd rather have the ical data put right in the schedule, and leave the notes section for notes! But I obviously understand that's a more significant challenge...

that would be much better, I agree.

I closed this PR as I need to work on a ruby branch version of it, so it might take some time, but the idea is here, and someone can re-work it if needed.

@kudrykv
Copy link
Owner

kudrykv commented Jan 24, 2024

Thank you for your idea and your work
I might take look into it next month. The idea looks interesting

However, calendar events are very much fleeting. Aside from putting some birthdays and holidays, I don't see a convenient way to flush new events into the planner and syncing it back to the device where it's being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants