Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add the VM as an observability addon #729

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

barnettZQG
Copy link
Collaborator

Description of your changes

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

@barnettZQG barnettZQG changed the title Feat: Add the VM as an addon Feat: Add the VM as a observability addon Sep 25, 2023
@barnettZQG barnettZQG changed the title Feat: Add the VM as a observability addon Feat: Add the VM as an observability addon Sep 25, 2023
@barnettZQG
Copy link
Collaborator Author

@wangyikewxgm @wonderflow PTAL

@barnettZQG barnettZQG merged commit 4e447da into kubevela:master Sep 26, 2023
2 of 3 checks passed
@wonderflow
Copy link
Collaborator

good work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants