Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service.md #47269

Closed
wants to merge 1 commit into from
Closed

Update service.md #47269

wants to merge 1 commit into from

Conversation

bxavi
Copy link

@bxavi bxavi commented Jul 25, 2024

Service type LoadBalancer has a property for clusterIP which should be loadBalancerIP for service type LoadBalancer.

Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @bxavi!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign salaxander for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 25, 2024
Copy link

netlify bot commented Jul 25, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d46e073
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a252b3eb95ed0008443b29
😎 Deploy Preview https://deploy-preview-47269--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

@bxavi Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: https://git.k8s.io/community/CLA.md

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@tengqm
Copy link
Contributor

tengqm commented Jul 26, 2024

No. This is not how a LB service works.
The ClusterIP's scope is for inside the cluster.
The LB IP is not supposed to be specified when you create a Service, it is
filled by the Service controller when an external load balancer is created.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@network-charles
Copy link
Contributor

Hi @bxavi, thanks for opening this PR. The loadBalancerIP field Is deprecated.

However, you can sign the CLA so you can open new PRs in the future.

@T-Lakshmi
Copy link
Contributor

Note:
The.spec.loadBalancerIP field for a Service was deprecated in Kubernetes v1.24.

/hold
Changes in this PR are not valid.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2024
@divya-mohan0209
Copy link
Contributor

@bxavi Please note that as mentioned above, the CLA requirements must be met before proceeding with the review. Since there has been no response from your end and as mentioned in the comments above, the change is invalid, we will close the PR.
/close

@k8s-ci-robot
Copy link
Contributor

@divya-mohan0209: Closed this PR.

In response to this:

@bxavi Please note that as mentioned above, the CLA requirements must be met before proceeding with the review. Since there has been no response from your end and as mentioned in the comments above, the change is invalid, we will close the PR.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants