Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release 1.29 to previousPatches in the schedule.yaml #44344

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

dipesh-rawat
Copy link
Member

@dipesh-rawat dipesh-rawat commented Dec 14, 2023

Resolves #44330

Additional Context:

Despite being reported for a single page, this is a broader site-wide issue affecting multiple pages using {{< skew currentPatchVersion >}}.

The shortcode "{{< skew currentPatchVersion >}}" seems to be struggling to determine the latest patch version with new 1.29 release. The current output from shortcode is %!f(string=1.).0. (see here). The quick fix involves updating the schedule.yaml to incorporate the latest version, v1.29.0, ensuring the shortcode displays the expected value.

Fixed Preview Page | Current Broken Website Page

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2023
Copy link

netlify bot commented Dec 14, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 416994d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/657a4bea34be27000860c562
😎 Deploy Preview https://deploy-preview-44344--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member Author

/cc @sftim @reylejano

This may require attention, particularly due to its wider impact including the Install Tools pages. With the new release, these pages will attract additional attention, as people may be interested in trying out the new release.

@sftim
Copy link
Contributor

sftim commented Dec 14, 2023

We should also fix the shortcode to work when there's no previous release listed. Would you like to file an issue about making that fix @dipesh-rawat ?

There is a fallback in the shortcode but I think it is buggy.

@sftim
Copy link
Contributor

sftim commented Dec 14, 2023

Thanks

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 17cf65b1a01e4e497b95cfbda86eace4c3bcfab2

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8cf0291 into kubernetes:main Dec 14, 2023
6 checks passed
@dipesh-rawat dipesh-rawat deleted the fix-shortcode branch December 14, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken info in “Install and Set Up kubectl on Windows”
3 participants