Reinstate the MultiCIDRRangeAllocator feature gate #44329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -793,6 +795,10 @@ In the following table: | |||
| - `MountPropagation`: Enable sharing volume mounted by one container to other containers or pods. | |||
| For more details, please see [mount propagation](/docs/concepts/storage/volumes/#mount-propagation). | |||
|
|
|||
| - `MultiCIDRRangeAllocator`: Enable IP address range allocation using | |||
| [ClusterCIDR]({{< relref "/docs/reference/kubernetes-api/cluster-resources/cluster-cidr-v1alpha1.md" >}}) | |||
There was a problem hiding this comment.
Nice! Today I learned about relref function.
|
Thanks for the fix! |
|
LGTM label has been added. Git tree hash: b18507d268458a222b808adb209b0896afcbf48e
|
There was a problem hiding this comment.
Thanks for catching the issue and for the fix, @sftim !
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divya-mohan0209 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Document MultiCIDRRangeAllocator as a deprecated feature gate.
32cea46
to
c30baa4
Compare
|
LGTM label has been added. Git tree hash: e6e675b88f534ee951adecd092b31642dc7ee058
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document
MultiCIDRRangeAllocatoras adeprecatedremoved feature gate.[preview]
It looks like the v1.29 release removed the docs entirely, which is different from the outcome we want.