-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REQUEST: Creation of cli-runtime and sample-cli-plugin repos #58
Comments
@soltysh Has sig-arch approved of new core repos? Was there a meeting agenda item or a mailing list thread where they do? cc: @jdumars @bgrant0607 |
@cblecker I've started this thread but haven't heard back, I assumed since there were no objections and both PRs merged (with top-level approval) I've created this issue. |
Note that having references to the k8s.io/cli-runtime package in the upcoming Kubernetes source will make it impossible to use packages like k8s.io/pkg/kubelet in other projects because tools like "go get" or "dep" don't know where to find the new package. I'm running into that when trying to use test/e2e/framework, which uses pkg/kubelet. |
This uses a fork of Kubernetes while the E2E refactoring (kubernetes/kubernetes#66649) is being worked on. cli-runtime must be pulled from a private repo because it is not yet on github.com/kubernetes (kubernetes/org#58).
@pohly the only reason for that is that we haven't published these repos yet, I just got approval so we will do so soon. @cblecker just got approval from @bgrant0607 see https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/kubernetes-sig-architecture/7UcXE9b0lQE/gPkl3BdhBgAJ |
/assign |
New repos requested in: kubernetes/org#58 kubernetes/org#56 Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
@soltysh can you add these to sigs.yaml under the appropriate subproject (or make new subproject entries for them if necessary?) will leave this open waiting for that PR, and to make sure the staging PR merges |
New repos requested in: kubernetes/org#58 kubernetes/org#56 Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
New repos requested in: kubernetes/org#58 kubernetes/org#56 Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
@spiffxp I've opened kubernetes/community#2647 to fix that. |
New repos requested in: kubernetes/org#58 kubernetes/org#56 Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
New repos requested in: kubernetes/org#58 kubernetes/org#56 Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
Current status:
@soltysh is there anything more specific you’d like the repo descriptions to be set to? I set them to the issue asking for their request out of habit, but assume it to be temporary |
@spiffxp I think we can do:
That will be sufficient. Thanks! |
/close |
@spiffxp: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@spiffxp thanks! |
To implement kubernetes/enhancements#581 and kubernetes/enhancements#579 we need 2 new repos. One contains library functions for writing plugins, the other shows how to use the first and write a sample CLI plugin.
New Repo, or migrate existing
Which Organization should it reside
kubernetes
Who should be provided access to this repository
We need admin access for the stage-bots team, compare:
![](https://user-images.githubusercontent.com/730123/45020493-70f73200-b02f-11e8-9a2e-797a1e9a2814.png)
![](https://user-images.githubusercontent.com/730123/45020616-c3d0e980-b02f-11e8-8e00-95e8e8f95e37.png)
We need branch settings like:
Approvals
https://github.com/kubernetes/community/blob/master/keps/sig-cli/0024-kubectl-plugins.md
kubernetes/kubernetes#67658
kubernetes/kubernetes#67938
/cc @juanvallejo @pwittrock @seans3
The text was updated successfully, but these errors were encountered: