Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Creation of cli-runtime and sample-cli-plugin repos #58

Closed
soltysh opened this issue Sep 4, 2018 · 12 comments
Closed

REQUEST: Creation of cli-runtime and sample-cli-plugin repos #58

soltysh opened this issue Sep 4, 2018 · 12 comments
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository

Comments

@soltysh
Copy link
Contributor

soltysh commented Sep 4, 2018

To implement kubernetes/enhancements#581 and kubernetes/enhancements#579 we need 2 new repos. One contains library functions for writing plugins, the other shows how to use the first and write a sample CLI plugin.

New Repo, or migrate existing

  • cli-runtime
  • sample-cli-plugin

Which Organization should it reside

kubernetes

Who should be provided access to this repository

We need admin access for the stage-bots team, compare:

We need branch settings like:

Approvals

https://github.com/kubernetes/community/blob/master/keps/sig-cli/0024-kubectl-plugins.md
kubernetes/kubernetes#67658
kubernetes/kubernetes#67938

/cc @juanvallejo @pwittrock @seans3

@cblecker
Copy link
Member

cblecker commented Sep 4, 2018

@soltysh Has sig-arch approved of new core repos? Was there a meeting agenda item or a mailing list thread where they do?

cc: @jdumars @bgrant0607

@soltysh
Copy link
Contributor Author

soltysh commented Sep 4, 2018

@cblecker I've started this thread but haven't heard back, I assumed since there were no objections and both PRs merged (with top-level approval) I've created this issue.

@pohly
Copy link
Contributor

pohly commented Sep 5, 2018

Note that having references to the k8s.io/cli-runtime package in the upcoming Kubernetes source will make it impossible to use packages like k8s.io/pkg/kubelet in other projects because tools like "go get" or "dep" don't know where to find the new package. I'm running into that when trying to use test/e2e/framework, which uses pkg/kubelet.

pohly added a commit to pohly/csi-e2e that referenced this issue Sep 5, 2018
This uses a fork of Kubernetes while the E2E
refactoring (kubernetes/kubernetes#66649) is
being worked on. cli-runtime must be pulled from a private repo
because it is not yet on
github.com/kubernetes (kubernetes/org#58).
@soltysh
Copy link
Contributor Author

soltysh commented Sep 6, 2018

@pohly the only reason for that is that we haven't published these repos yet, I just got approval so we will do so soon.

@cblecker just got approval from @bgrant0607 see https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/kubernetes-sig-architecture/7UcXE9b0lQE/gPkl3BdhBgAJ

@cblecker cblecker self-assigned this Sep 6, 2018
@spiffxp
Copy link
Member

spiffxp commented Sep 6, 2018

/assign

@spiffxp
Copy link
Member

spiffxp commented Sep 7, 2018

@soltysh can you add these to sigs.yaml under the appropriate subproject (or make new subproject entries for them if necessary?)

will leave this open waiting for that PR, and to make sure the staging PR merges

sttts pushed a commit to sttts/publishing-bot that referenced this issue Sep 7, 2018
New repos requested in:
kubernetes/org#58
kubernetes/org#56

Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
dims added a commit to dims/publishing-bot that referenced this issue Sep 7, 2018
New repos requested in:
kubernetes/org#58
kubernetes/org#56

Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
@soltysh
Copy link
Contributor Author

soltysh commented Sep 7, 2018

@spiffxp I've opened kubernetes/community#2647 to fix that.

dims added a commit to dims/publishing-bot that referenced this issue Sep 7, 2018
New repos requested in:
kubernetes/org#58
kubernetes/org#56

Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
sttts pushed a commit to sttts/publishing-bot that referenced this issue Sep 7, 2018
New repos requested in:
kubernetes/org#58
kubernetes/org#56

Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
@cblecker cblecker removed their assignment Sep 10, 2018
@spiffxp
Copy link
Member

spiffxp commented Sep 10, 2018

Current status:

  • The repos look to be synced by publishing-bot now

@soltysh is there anything more specific you’d like the repo descriptions to be set to? I set them to the issue asking for their request out of habit, but assume it to be temporary

@soltysh
Copy link
Contributor Author

soltysh commented Sep 14, 2018

@spiffxp I think we can do:

  • cli-runtime - Set of helpers for creating kubectl commands and plugins.
  • sample-cli-plugin - Sample kubectl plugin.

That will be sufficient. Thanks!

@spiffxp
Copy link
Member

spiffxp commented Sep 18, 2018

/close
descriptions have been set

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
descriptions have been set

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Contributor Author

soltysh commented Sep 19, 2018

@spiffxp thanks!

@spiffxp spiffxp added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository
Projects
None yet
Development

No branches or pull requests

5 participants