-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubelet cert TTL via GaugeFunc #85874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for iterating over this!
staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/metrics_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/component-base/metrics/prometheus/restclient/metrics.go
Show resolved
Hide resolved
…func for calculating time remaining.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sambdavidson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rewrote the Kubelet client and serving certificate packages to use a GaugeFunc instead of a traditional Gauge. This allows them both to accurately report the TTL of their certificates at read time rather than arbitrary setting the TTL in unrelated threads.
The metric
certificate_manager_server_expiration_seconds
has been renamed tocertificate_manager_server_ttl_seconds
and its behavior has changed from reporting an absolute time, to reporting the seconds remaining e.g. date seconds since epoch like1257894000
-> remaining seconds like1234
.The behavior of
rest_client_exec_plugin_ttl_seconds
remains the same it has just become more accurate when read.What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Building off of new client cert metrics (#84382), new serving cert metrics (#84534), and a GaugeFunc implementation (#83830). We now have accurate insights into Kubetlet certificate rotations and TTL. This provides visibility towards efforts of shortening certificate lifetimes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/assign @awly @logicalhan @liggitt