Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch pod eviction client from v1alpha1 to v1beta #36651

Merged
merged 3 commits into from
Nov 11, 2016
Merged

Switch pod eviction client from v1alpha1 to v1beta #36651

merged 3 commits into from
Nov 11, 2016

Conversation

mwielgus
Copy link
Contributor

@mwielgus mwielgus commented Nov 11, 2016 •
edited by k8s-oncall
Loading

Generated client 1.5 has a function to evict a pod. The function uses v1alpha1.Eviction object instead of v1beta1. This pr changes the api version that is being used.

cc: @davidopp @caesarxuchao

This change is Reviewable

@mwielgus mwielgus added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 11, 2016
@mwielgus mwielgus added this to the v1.5 milestone Nov 11, 2016
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 11, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 054ea932f229de61a1a36dec79f4fa688bc2bfc3. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@caesarxuchao
Copy link
Member

Thanks @mwielgus . Could you also run hack/udpate-staging-client-go.sh?

@mwielgus
Copy link
Contributor Author

client-go updated. PTAL.

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 11, 2016
@caesarxuchao
Copy link
Member

LGTM. Thanks.

@caesarxuchao caesarxuchao added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@davidopp
Copy link
Member

Thanks @mwielgus. I assume this is a bug fix, and not something we need to file an exception request for?

@caesarxuchao
Copy link
Member

Yes, it's an bug fix.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 2822e4f into kubernetes:master Nov 11, 2016
@saad-ali
Copy link
Member

Thanks @mwielgus. I assume this is a bug fix, and not something we need to file an exception request for?
Yes, it's an bug fix.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caesarxuchao caesarxuchao

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
7 participants
@mwielgus @k8s-ci-robot @caesarxuchao @k8s-github-robot @davidopp @saad-ali @googlebot