Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build statically linked binaries in makefile; remove make clean #99

Merged
merged 2 commits into from
Aug 11, 2016

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Aug 11, 2016

Fixes #98

Now make binary, make all or make default gives me statically linked binaries:

$ ldd bundles/kompose_linux-amd64/kompose 
    not a dynamic executable
$ file bundles/kompose_linux-amd64/kompose 
bundles/kompose_linux-amd64/kompose: ELF 64-bit LSB  executable, x86-64, version 1 (SYSV), statically linked, not stripped

Also removed make clean since the clean script doesn't exist.

@ngtuna
Copy link
Contributor

ngtuna commented Aug 11, 2016

+1 @janetkuo .

@ngtuna ngtuna added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2016
@pradeepto
Copy link

@janetkuo @ngtuna But we should have a clean directive, I think. Not sure how it works in Goland but, it definitely made a lot of sense in C/C++ world. We probably want something to make sure we have a pristine build. What do you all think?

@janetkuo
Copy link
Member Author

@pradeepto Yes we should support make clean, and we can add it back once we have the clean script

@janetkuo janetkuo merged commit 52a933c into kubernetes:master Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants