Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fix #981

Merged
merged 3 commits into from
Apr 4, 2018
Merged

typo fix #981

merged 3 commits into from
Apr 4, 2018

Conversation

jonyhy96
Copy link

@jonyhy96 jonyhy96 commented Apr 3, 2018

typo fix

None

typo fix
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2018
@hangyan
Copy link
Contributor

hangyan commented Apr 3, 2018

@jonyhy96 Since this PR is very similar to #980, can you merge the commits and only open one PR, there is no need to create seperate PRs.

@jonyhy96
Copy link
Author

jonyhy96 commented Apr 3, 2018

@hangyan
Thansk for your reply and i will close the other PR.

typo fix
@jonyhy96 jonyhy96 mentioned this pull request Apr 3, 2018
@hangyan
Copy link
Contributor

hangyan commented Apr 3, 2018

@jonyhy96 Since you have create a PR to fix the initialize typo, can you fix all the same typo that appears in the code ?

@jonyhy96
Copy link
Author

jonyhy96 commented Apr 3, 2018

@hangyan
I think i already fix all the initialize typo in this code.
Please help me to specify where the same typo is and i will correct it.
Thx.

@hangyan
Copy link
Contributor

hangyan commented Apr 3, 2018

github.com/kubernetes/kompose ∙ grep "initialize" -R * |grep -v vendor                                                                                           130 ↵ ᚴ master 3≡
Binary file kompose matches
pkg/app/app.go:		// Create/Init new OpenShift object that is initialized with a newly
pkg/transformer/openshift/openshift.go:https:// initImageStream initialize ImageStream object
pkg/transformer/openshift/openshift.go:https:// initDeploymentConfig initialize OpenShifts DeploymentConfig object
pkg/transformer/openshift/openshift.go:	// initialize OpenShift Client
pkg/transformer/kubernetes/kubernetes.go:https:// InitRC initializes Kubernetes ReplicationController object
pkg/transformer/kubernetes/kubernetes.go:https:// InitSvc initializes Kubernetes Service object
pkg/transformer/kubernetes/kubernetes.go:https:// InitConfigMap initialized a ConfigMap object
pkg/transformer/kubernetes/kubernetes.go:https:// InitD initializes Kubernetes Deployment object
pkg/transformer/kubernetes/kubernetes.go:https:// InitDS initializes Kubernetes DaemonSet object
pkg/transformer/kubernetes/kubernetes.go:https:// CreatePVC initializes PersistentVolumeClaim
pkg/transformer/kubernetes/kubernetes.go:https:// InitPod initializes Kubernetes Pod object

@jonyhy96

@jonyhy96
Copy link
Author

jonyhy96 commented Apr 3, 2018

@hangyan
Thanks for your help.
I will fix this as soon as possible.
Hope one day i can be a great coder just like you.:D

typo fix
@jonyhy96
Copy link
Author

jonyhy96 commented Apr 3, 2018

@hangyan
I think i already fix all initialize typo.How do you think?

@hangyan
Copy link
Contributor

hangyan commented Apr 3, 2018

looks good. you can merge all the commits into one and a little suggestion: also fix the commit message. (you can check this article: https://chris.beams.io/posts/git-commit/)

@jonyhy96

@jonyhy96
Copy link
Author

jonyhy96 commented Apr 3, 2018

@hangyan
Thanks for your help!You are really a nice person!
I'm still a newbie on this and i wll watch out this in the future!:D

@hangyan
Copy link
Contributor

hangyan commented Apr 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2018
@cdrage
Copy link
Member

cdrage commented Apr 4, 2018

Thanks all 👍 This LGTM too!

@cdrage cdrage merged commit f671ca9 into kubernetes:master Apr 4, 2018
@hangyan
Copy link
Contributor

hangyan commented Apr 4, 2018

Wouldn't be better for him to merge the commits before we merge this PR.

@jonyhy96 jonyhy96 deleted the patch-1 branch April 4, 2018 17:27
@cdrage
Copy link
Member

cdrage commented Apr 4, 2018

Woops. I didn't catch that. My mistake! I should of pressed the "merge commits" button. But yes, it should of been merged into one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants