-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo fix #981
typo fix #981
Conversation
@hangyan |
@jonyhy96 Since you have create a PR to fix the |
@hangyan |
|
@hangyan |
@hangyan |
looks good. you can merge all the commits into one and a little suggestion: also fix the commit message. (you can check this article: https://chris.beams.io/posts/git-commit/) |
@hangyan |
/lgtm |
Thanks all 👍 This LGTM too! |
Wouldn't be better for him to merge the commits before we merge this PR. |
Woops. I didn't catch that. My mistake! I should of pressed the "merge commits" button. But yes, it should of been merged into one. |
typo fix