Output List kind object when using stdout #94
Conversation
|
@ngtuna rebased on the current master and now working to make charts output workable |
|
There are currently two issues with the chart creation, first it
|
| osDC := initDeploymentConfig(name, service, opt.replicas) // OpenShift DeploymentConfigs | ||
|
|
||
| var controller runtime.Object | ||
| // only one controller will be created per service so using switch |
There was a problem hiding this comment.
Multiple controllers can be created at once as long as --stdout or --out isn't specified
There was a problem hiding this comment.
I am confused here, why would we have multiple controllers when --stdout or --out is not given?
There was a problem hiding this comment.
That's strategy: we give user option to generate multiple controllers at the same time like this kompose convert --ds --rc. However when he uses --stdout or --out flag, the common case will be using it in a pipeline, only default primitives (deployment and service) are created.
There was a problem hiding this comment.
Oh now I get it, thanks for the clarification 👍 will update it and make changes.
| file = print(t.Name, strings.ToLower(t.Kind), data, opt.toStdout, opt.generateYaml, f) | ||
| case *extensions.Deployment: | ||
| file = print(t.Name, strings.ToLower(t.Kind), data, opt.toStdout, opt.generateYaml, f) | ||
| case *extensions.ReplicaSet: |
There was a problem hiding this comment.
we don't support ReplicaSet anymore
Now user gets a `List` kind object when putting eveything on stdout or in a single file. Fixes kubernetes#73
|
For the thing about having services first I have created a function https://github.com/skippbox/kompose/pull/94/files#diff-41d801ef80f1858d5e8e9695667e4dafR1302 called from Up https://github.com/skippbox/kompose/pull/94/files#diff-41d801ef80f1858d5e8e9695667e4dafR1281 |
ngtuna
added
the
lgtm
Now user gets a
Listkind object when putting eveything on stdout or in a single file.Fixes #73