Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable name should not be the same as imported package name #937

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

hangyan
Copy link
Contributor

@hangyan hangyan commented Feb 9, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 9, 2018
@hangyan
Copy link
Contributor Author

hangyan commented Feb 12, 2018

@surajnarwade @cdrage CI seems unstable..

@cdrage
Copy link
Member

cdrage commented Feb 13, 2018

@hangyan Yeah, looks like the Fedora build system went down temporarily. I've gone ahead and restarted the build.

@hangyan
Copy link
Contributor Author

hangyan commented Feb 14, 2018

@cdrage how do i re-trigger the build?

@cdrage
Copy link
Member

cdrage commented Feb 20, 2018

@hangyan If you do a force update, it can re-trigger the build (for example, using git commit --amend and amending the message and updating the PR).

I've triggered a rebuild manually however..

@hangyan
Copy link
Contributor Author

hangyan commented Feb 23, 2018

@cdrage CI passed

@cdrage cdrage merged commit bccc563 into kubernetes:master Feb 23, 2018
@hangyan hangyan deleted the fix-code-style branch March 31, 2018 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants