Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on travis-ci #93

Merged
merged 7 commits into from
Aug 11, 2016
Merged

Run tests on travis-ci #93

merged 7 commits into from
Aug 11, 2016

Conversation

kadel
Copy link
Member

@kadel kadel commented Aug 9, 2016

related to #34

  • run commandline tests and unit test on travis-ci (make test-unit and make test-cmd)
  • make binary builds only binary for current arch platform where script is running (no cross compiling)
  • added make binary-cross same as former make binary (cross compile for mac/linux/win 386/amd65)

command line test is failing because of #88 and #92

@sebgoa
Copy link
Contributor

sebgoa commented Aug 9, 2016

+1, we just need to check the tests

@ngtuna
Copy link
Contributor

ngtuna commented Aug 9, 2016

👍 @kadel. I will check this after dinner.

@ngtuna
Copy link
Contributor

ngtuna commented Aug 10, 2016

@kadel I tested on ubuntu 16.04.

  • make binary-cross doesn't output binaries.
  • make binary-cross and make binary doesn't print anything. It would be better to print output then user can see what's happening like this:
$ make binary
./script/make.sh binary
---> Making bundle: binary (in .)

Number of parallel builds: 1

-->   windows/amd64: github.com/skippbox/kompose/cli/main
-->       linux/386: github.com/skippbox/kompose/cli/main
-->      darwin/386: github.com/skippbox/kompose/cli/main
-->    darwin/amd64: github.com/skippbox/kompose/cli/main
-->     linux/amd64: github.com/skippbox/kompose/cli/main
-->     windows/386: github.com/skippbox/kompose/cli/main

@kadel
Copy link
Member Author

kadel commented Aug 10, 2016

ahh my bad 😄 make binary-cross points to makes.sh binary, to it just builds for current platform :-) I'll fix that and I'll also add info about successful build for make binary.

Thank you for noticing that.

@ngtuna ngtuna added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2016
@kadel kadel merged commit e7dfff5 into kubernetes:master Aug 11, 2016
@kadel kadel deleted the travis-tests branch August 30, 2016 11:36
@kadel kadel restored the travis-tests branch August 30, 2016 11:37
@kadel kadel deleted the travis-tests branch August 30, 2016 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants