enhance warning: networks, network config, volume config. Fixes #88, #71 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #75 as well |
|
Nice LGTM! |
| @@ -854,8 +854,25 @@ func loadComposeFile(file string, opt convertOptions) KomposeObject { | |||
|
|
|||
| // transform composeObject into komposeObject | |||
| composeServiceNames := composeObject.ServiceConfigs.Keys() | |||
|
|
|||
| // volume config and network config has not supported | |||
|
@janetkuo: I added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@janetkuo : I added warning for
volume configandnetwork config.@surajssd :
networkskey is checked. However, please take a look at FIXME and leave me your thought.