New behavior of kompose up #86
Conversation
| // logrus.Debugf("%s\n", rcCreated) | ||
| // } | ||
| //} | ||
| logrus.Infof("We are going to create deployment controller and service for your dockerized application. \n" + |
There was a problem hiding this comment.
Change all "Deployment controller" to "Deployment" or "Kubernetes Deployment" (when we say deployment controller we usually mean the thing that's responsible for creating/syncing Deployments, part of kube controller manager).
|
How do we handle the case that the converted k8s object is invalid (missing required fields)? Users would enter a weird state that their dockerized / kubernized apps are created partially. $ kompose up -f docker-voting.yml
We are going to create deployment controller and service for your dockerized application.
If you need more kind of controllers, consider to use kompose convert and kubectl.
WARN[0000] Unsupported key networks - ignoring
WARN[0000] Unsupported key build - ignoring
WARN[0000] [worker] Service cannot be created because of missing port.
WARN[0000] [db] Service cannot be created because of missing port.
Service result has been created.
Service vote has been created.
FATA[0000] Failed to unmarshal worker to service object: unexpected end of JSON inputSomething to think about. We may fix it in a follow-up PR. |
| factory := cmdutil.NewFactory(nil) | ||
| clientConfig, err := factory.ClientConfig() | ||
| if err != nil { | ||
| logrus.Fatalf("Failed to get Kubernetes client config: %v", err) |
There was a problem hiding this comment.
"Failed to get Kubernetes client config" --> "Failed to get config for accessing the Kubernetes server"
| @@ -1265,10 +1284,12 @@ func Up(c *cli.Context) { | |||
| if err != nil { | |||
| logrus.Fatalf("Failed to create deployment controller %s: ", k, err) | |||
| } else { | |||
| fmt.Println("Deployment controller " + k + " has been created.") | |||
| fmt.Printf("Deployment controller %q has been created.\n", k) | |||
There was a problem hiding this comment.
Deployment controller --> Deployment
|
Thanks @janetkuo. I fixed it with an 'amended' commit. |
Fix #40
/cc @janetkuo